| title: | Re PATCH CLKDEV return from clk find as s |
|
Hello,
On Tue, Mar 02, 2010 at 08:39:11PM +0000, Russell King - ARM Linux wrote:
On Tue, Mar 02, 2010 at 04:35:54PM +0530, Viresh KUMAR wrote:
clk_find function looks for clock with matching dev_id and con_id.
We should return from clk_find as soon as we get a clock with matching dev_id
and con_id. This can be done by comparing variable "match" with 3.
This breaks the semantics function. Please look again at the code youre
modifying, and ascertain whether youre changing the semantics of it,
particularly with respect to what happens _in addition_ to returning the
struct clk.
Hint: "return p- clk" is insufficient.
I starred a the code a bit, but I dont see the problem here. match is
always <= 3 so if it is 3 in one iteration best increases to 3 and clk
isnt touched anymore. The other statements in the loop have no side
effects either.
Apart from that a while back I thought about removing
if (match == 0)
continue;
as if match is 0 the next if condition is false. I dont remember why I
didnt do it. Maybe I checked the generated code and it made no
difference.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | rel="nofollow" www.pengutronix.de/ www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
rel="nofollow" lists.infradead.org/mailman/listinfo/linux-arm-kernel lists.infradead.org/mailman/listinfo/linux-arm-kernel
|
